Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playlist: Add auto-update functionality and more tests #3151

Merged
merged 14 commits into from
Feb 18, 2019

Conversation

Holzhaus
Copy link
Contributor

This is round two for the playlist plugin:

This improves the existing tests (and adds some more to ensure nothing breaks), and also adds the auto-update functionality that I described in issue #123:

If the auto is set, then whenever a database item is moved or removed, the playlists inside the playlist_dir are updated to reflect that change.

@Holzhaus
Copy link
Contributor Author

"Trial and error" works surprisingly well when fixing issues with Windows without access to an installation btw ;-)

Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Here are just a couple of very small suggestions.

beetsplug/playlist.py Outdated Show resolved Hide resolved
beetsplug/playlist.py Outdated Show resolved Hide resolved
@sampsyo
Copy link
Member

sampsyo commented Feb 18, 2019

Awesome! Nice work again!!

@sampsyo sampsyo merged commit 81c5ae3 into beetbox:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants